Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames
Date	2017-10-01 19:50 +0200
Message-ID	<uvQxk-536-5@gated-at.bofh.it> (permalink)
References	<umJ21-2yd-3@gated-at.bofh.it> <umJ23-2yd-45@gated-at.bofh.it> <urpP5-5pF-21@gated-at.bofh.it> <uvLHk-2as-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 2017-10-01 at 14:37 +0200, Milian Wolff wrote:
> On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
[]
> > nit, think we prefer the /* */ comment style
> 
> I'll fix this, but note that there are more places outside this patch series 
> where this style has crept in. Some of them also from past patches of mine - 
> sorry for that.

I think c99 comments are fine.
So did Linus Torvalds.

http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html

> I looks to me as if the checkpatch.pl should catch this, but it doesn't for me 
> which is odd. Does anyone know what I need to do to enable the C99_COMMENTS 
> check?

Modify checkpatch

my $allow_c99_comments = 1;

change the 1 to 0

Add a runtime option if you want.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames Milian Wolff <milian.wolff@kdab.com> - 2017-10-01 14:40 +0200
  Re: [PATCH v3 03/13] perf report: create real callchain entries for  inlined frames Joe Perches <joe@perches.com> - 2017-10-01 19:50 +0200

csiph-web