Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines
Date	2017-10-01 17:20 +0200
Message-ID	<uvOca-3Ly-15@gated-at.bofh.it> (permalink)
References	<utRnQ-Tp-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Tue, Sep 26, 2017 at 11:46:14AM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, queued.

-- Sebastian

> ---
>  drivers/hsi/clients/hsi_char.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
> index 57f70c2..cf9c2a3 100644
> --- a/drivers/hsi/clients/hsi_char.c
> +++ b/drivers/hsi/clients/hsi_char.c
> @@ -773,13 +773,13 @@ static int __init hsc_init(void)
>  
>  	if ((max_data_size < 4) || (max_data_size > 0x10000) ||
>  		(max_data_size & (max_data_size - 1))) {
> -		pr_err("Invalid max read/write data size");
> +		pr_err("Invalid max read/write data size\n");
>  		return -EINVAL;
>  	}
>  
>  	ret = hsi_register_client_driver(&hsc_driver);
>  	if (ret) {
> -		pr_err("Error while registering HSI/SSI driver %d", ret);
> +		pr_err("Error while registering HSI/SSI driver %d\n", ret);
>  		return ret;
>  	}
>  
> -- 
> 1.9.1
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines Sebastian Reichel <sre@kernel.org> - 2017-10-01 17:20 +0200

csiph-web