Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742808

Re: hwmon: (w83793): make const array watchdog_minors static, reduces object code size

Show all headers | View raw

On Fri, Sep 22, 2017 at 03:36:20PM +0100, Colin Ian King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate const array watchdog_minors on the stack, instead make it
> static. Makes the object code smaller by over 350 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   48019	  38144	    256	  86419	  15193	drivers/hwmon/w83793.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   47574	  38232	    256	  86062	  1502e	drivers/hwmon/w83793.o
> 
> (gcc 6.3.0, x86-64)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/w83793.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
> index dab5c515d5a3..5ba9d9f1daa1 100644
> --- a/drivers/hwmon/w83793.c
> +++ b/drivers/hwmon/w83793.c
> @@ -1676,7 +1676,9 @@ static int w83793_probe(struct i2c_client *client,
>  			const struct i2c_device_id *id)
>  {
>  	struct device *dev = &client->dev;
> -	const int watchdog_minors[] = { WATCHDOG_MINOR, 212, 213, 214, 215 };
> +	static const int watchdog_minors[] = {
> +		WATCHDOG_MINOR, 212, 213, 214, 215
> +	};
>  	struct w83793_data *data;
>  	int i, tmp, val, err;
>  	int files_fan = ARRAY_SIZE(w83793_left_fan) / 7;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: hwmon: (w83793): make const array watchdog_minors static,  reduces object code size Guenter Roeck <linux@roeck-us.net> - 2017-10-01 16:20 +0200

csiph-web