Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices
Date	2017-10-01 16:50 +0200
Message-ID	<uvNJ8-3mp-11@gated-at.bofh.it> (permalink)
References	<umeKB-73c-3@gated-at.bofh.it> <umeKB-73c-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 5, 2017 at 8:37 AM,
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Currently, we have lot of repetitive code in dependent device resource
> allocation and device creation handling code. This logic can be improved if
> we use MFD framework for dependent device creation. This patch adds this
> support.
>

> +       punit_cell.id = -1;

> +       return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,
> +                       &punit_cell, 1, NULL, 0, NULL);

IIRC you don't need to file cell ID in case of DEVID_AUTO.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to  create dependent devices Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-10-01 16:50 +0200

csiph-web