Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742279
| From | <Tristram.Ha@microchip.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH RFC 3/5] Add KSZ8795 switch driver |
| Date | 2017-09-29 20:50 +0200 |
| Message-ID | <uv8wh-1rx-17@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <unnCa-4LB-13@gated-at.bofh.it> <unvJo-1M9-17@gated-at.bofh.it> <unztE-4m3-19@gated-at.bofh.it> <unD4d-6Yq-1@gated-at.bofh.it> <uuIVc-2ep-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> > > > > Similar code will be needed by other drivers, right? > > > > > > > > Although KSZ8795 and KSZ8895 may use the same code, the other > > > > chips will have different code. > > > > > > Ok, please make sure code is shared between these two. > > > > The exact function probably cannot be shared between KSZ8795 > > and KSZ8895 drivers because although the register constants look > > the same but their exact locations are different in the 2 chips. > > Put the code into header as static inline and include it from both > places? > Although KSZ8795 and KSZ8895 share the same code when simulating the PHY register access, even though the exact registers are not the same, this code needs a little modification for another chip. It also looks too large to put in a header.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH RFC 3/5] Add KSZ8795 switch driver Pavel Machek <pavel@ucw.cz> - 2017-09-28 17:30 +0200
RE: [PATCH RFC 3/5] Add KSZ8795 switch driver <Tristram.Ha@microchip.com> - 2017-09-29 20:50 +0200
Re: [PATCH RFC 3/5] Add KSZ8795 switch driver Pavel Machek <pavel@ucw.cz> - 2017-10-01 09:30 +0200
csiph-web