Re: [PATCH net-next 2/8] net: dsa: directly fetch switch in lan9303_rcv

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 2/8] net: dsa: directly fetch switch in lan9303_rcv
Date	2017-09-29 21:10 +0200
Message-ID	<uv8PD-1NK-11@gated-at.bofh.it> (permalink)
References	<uv8wh-1rx-5@gated-at.bofh.it> <uv8wh-1rx-7@gated-at.bofh.it> <uv8PD-1NK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Florian,

Florian Fainelli <f.fainelli@gmail.com> writes:

>> @@ -72,11 +72,10 @@ static struct sk_buff *lan9303_rcv(struct sk_buff *skb, struct net_device *dev,
>>  {
>>  	u16 *lan9303_tag;
>>  	struct dsa_switch_tree *dst = dev->dsa_ptr;
>> -	struct dsa_switch *ds;
>> +	struct dsa_port *cpu_dp = dst->cpu_dp;
>> +	struct dsa_switch *ds = cpu_dp->ds;
>>  	unsigned int source_port;
>>  
>> -	ds = dst->ds[0];
>> -
>>  	if (unlikely(!ds)) {
>>  		dev_warn_ratelimited(&dev->dev, "Dropping packet, due to missing DSA switch device\n");
>>  		return NULL;
>
> Similarly to the patch before, you can probably drop this test, I don't
> actually see how we could trigger it.

Good catch, I'll respin after eventually more reviews.


Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 2/8] net: dsa: directly fetch switch in lan9303_rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-29 20:50 +0200
  Re: [PATCH net-next 2/8] net: dsa: directly fetch switch in  lan9303_rcv Florian Fainelli <f.fainelli@gmail.com> - 2017-09-29 21:10 +0200
    Re: [PATCH net-next 2/8] net: dsa: directly fetch switch in lan9303_rcv Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-29 21:10 +0200

csiph-web