Re: [PATCH] IB/qib: Use setup_timer and mod_timer

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/qib: Use setup_timer and mod_timer
Date	2017-09-29 17:30 +0200
Message-ID	<uv5oK-7Wg-9@gated-at.bofh.it> (permalink)
References	<utdJL-8er-7@gated-at.bofh.it>
Organization	Red Hat, Inc.

Show all headers | View raw

On Sun, 2017-09-24 at 17:21 +0530, Himanshu Jha wrote:
> Use setup_timer and mod_timer API instead of structure assignments.
> 
> This is done using Coccinelle and semantic patch used
> for this as follows:
> 
> @@
> expression x,y,z,a,b;
> @@
> 
> -init_timer (&x);
> +setup_timer (&x, y, z);
> +mod_timer (&a, b);
> -x.function = y;
> -x.data = z;
> -x.expires = b;
> -add_timer(&a);
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] IB/qib: Use setup_timer and mod_timer Doug Ledford <dledford@redhat.com> - 2017-09-29 17:30 +0200

csiph-web