Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742198

Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings

Show all headers | View raw

On Fri, 2017-09-29 at 14:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The functions hns_roce_table_mhop_get, hns_roce_table_mhop_put,
> hns_roce_cleanup_mhop_hem_table,  hns_roce_v1_post_mbox,
> hns_roce_cmq_setup_basic_desc, hns_roce_cmq_send,
> hns_roce_cmq_query_hw_info are all local to the source and do
> not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'hns_roce_table_mhop_get' was not declared. Should it be
> static?
> symbol 'hns_roce_table_mhop_put' was not declared. Should it be
> static?
> symbol 'hns_roce_cleanup_mhop_hem_table' was not declared. Should it
> be
> static?
> symbol 'hns_roce_v1_post_mbox' was not declared. Should it be static?
> symbol 'hns_roce_cmq_setup_basic_desc' was not declared. Should it be
> static?
> symbol 'hns_roce_cmq_send' was not declared. Should it be static?
> symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be
> static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings Colin King <colin.king@canonical.com> - 2017-09-29 15:20 +0200
  Re: [PATCH][rdma-next] RDMA/hns: make various function static,  fixes warnings Doug Ledford <dledford@redhat.com> - 2017-09-29 17:30 +0200

csiph-web