[PATCH] mm/hugetlbfs: Remove the redundant -ENIVAL return from hugetlbfs_setattr()

From	Anshuman Khandual <khandual@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH] mm/hugetlbfs: Remove the redundant -ENIVAL return from hugetlbfs_setattr()
Date	2017-09-29 17:00 +0200
Message-ID	<uv4VJ-7x1-37@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There is no need to have a local return code set with -EINVAL when both the
conditions following it return error codes appropriately. Just remove the
redundant one.

Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
 fs/hugetlbfs/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 59073e9..cff3939 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -668,7 +668,6 @@ static int hugetlbfs_setattr(struct dentry *dentry, struct iattr *attr)
 		return error;
 
 	if (ia_valid & ATTR_SIZE) {
-		error = -EINVAL;
 		if (attr->ia_size & ~huge_page_mask(h))
 			return -EINVAL;
 		error = hugetlb_vmtruncate(inode, attr->ia_size);
-- 
1.8.5.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/hugetlbfs: Remove the redundant -ENIVAL return from hugetlbfs_setattr() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-09-29 17:00 +0200
  Re: [PATCH] mm/hugetlbfs: Remove the redundant -ENIVAL return from  hugetlbfs_setattr() Mike Kravetz <mike.kravetz@oracle.com> - 2017-09-29 19:50 +0200

csiph-web