Groups > linux.kernel > #1742092

Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()

From	Morten Rasmussen <morten.rasmussen@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares()
Date	2017-09-29 15:10 +0200
Message-ID	<uv3df-6Af-21@gated-at.bofh.it> (permalink)
References	<ukUkV-5wR-5@gated-at.bofh.it> <ukUkW-5wR-17@gated-at.bofh.it> <uuDVv-7Gp-7@gated-at.bofh.it> <uv1Ob-5yp-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 29, 2017 at 01:35:00PM +0200, Peter Zijlstra wrote:
> On Thu, Sep 28, 2017 at 11:03:03AM +0100, Morten Rasmussen wrote:
> > IIUC, if grq->avg.load_avg > grq->load.weight, i.e. you have blocked
> > tasks, you can end up with underestimating the ge->load.weight for some
> > of the group entities lead to \Sum ge->load.weight < tg->weight.
> 
> Ah yes, you're right. However, if you look at the end of the series we
> actually end up with using:
> 
> 	max(grq->load.weight, grq->avg.load_avg)
> 
> Which I suppose makes it true again.

Yes, with the next patch in the series, underestimation is no longer
possible.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares() Morten Rasmussen <morten.rasmussen@arm.com> - 2017-09-28 12:10 +0200
  Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares() Peter Zijlstra <peterz@infradead.org> - 2017-09-29 13:40 +0200
    Re: [PATCH -v2 02/18] sched/fair: Add comment to calc_cfs_shares() Morten Rasmussen <morten.rasmussen@arm.com> - 2017-09-29 15:10 +0200

csiph-web