Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741188

linux-next: build failure after merge of the ipmi tree

Show all headers | View raw

Hi Corey,

After merging the ipmi tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, of_ipmi_match);
 ^
drivers/char/ipmi/ipmi_si_platform.c:360:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: parameter names (without types) in function declaration
drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(pci, ipmi_pci_devices);
 ^
drivers/char/ipmi/ipmi_si_pci.c:142:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: parameter names (without types) in function declaration

Caused by commits

  a3f3086dd508 ("ipmi_si: Move platform device handling to another file")
  fb5d20a966cf ("ipmi_si: Move PCI setup to another file

Probably missing include files.

I have added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 Sep 2017 14:40:49 +1000
Subject: [PATCH] ipmi_si: MODULE_DEVICE_TABLE needs module.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/ipmi/ipmi_si_pci.c      | 2 +-
 drivers/char/ipmi/ipmi_si_platform.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
index ad0b7b6ad250..99771f5cad07 100644
--- a/drivers/char/ipmi/ipmi_si_pci.c
+++ b/drivers/char/ipmi/ipmi_si_pci.c
@@ -3,7 +3,7 @@
  *
  * Handling for IPMI devices on the PCI bus.
  */
-#include <linux/moduleparam.h>
+#include <linux/module.h>
 #include <linux/pci.h>
 #include "ipmi_si.h"
 
diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
index 0e7ff0a4a151..9573f1116450 100644
--- a/drivers/char/ipmi/ipmi_si_platform.c
+++ b/drivers/char/ipmi/ipmi_si_platform.c
@@ -5,7 +5,7 @@
  * coming from the platform.
  */
 #include <linux/types.h>
-#include <linux/moduleparam.h>
+#include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/of_platform.h>
 #include <linux/of_address.h>
-- 
2.14.1

-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the ipmi tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-09-28 06:50 +0200
  Re: linux-next: build failure after merge of the ipmi tree Corey Minyard <minyard@acm.org> - 2017-09-28 19:40 +0200

csiph-web