Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741144

Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution

Show all headers | View raw

On Mon, Sep 18, 2017 at 08:43:18AM -0700, Chintan Patel wrote:
> Jack name is not getting formatted correctly hence resulting
> in invalid name for HDMI/DP input devices.
> 
> This was recently exposed due changes brought by MST:
> commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize
> in kbl machine drivers")

Acked-By: Vinod Koul <vinod.koul@intel.com>

> 
> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
>  sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> index 4689991bcc86..c127b7b0ee3f 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> @@ -611,6 +611,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
>  
>  	list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
>  		codec = pcm->codec_dai->codec;
> +		snprintf(jack_name, sizeof(jack_name),
> +			"HDMI/DP, pcm=%d Jack", pcm->device);
>  		err = snd_soc_card_jack_new(card, jack_name,
>  				SND_JACK_AVOUT, &ctx->kabylake_hdmi[i],
>  				NULL, 0);
> -- 
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

-- 
~Vinod

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Fix jack name format  substitution Vinod Koul <vinod.koul@intel.com> - 2017-09-28 05:10 +0200

csiph-web