Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741034

[PATCH 2/2] percpu: fix iteration to prevent skipping over block

Show all headers | View raw

The iterator functions pcpu_next_md_free_region and
pcpu_next_fit_region use the block offset to determine if they have
checked the area in the prior iteration. However, this causes an issue
when the block offset is greater than subsequent block contig hints. If
within the iterator it moves to check subsequent blocks, it may fail in
the second predicate due to the block offset not being cleared. Thus,
this causes the allocator to skip over blocks leading to false failures
when allocating from the reserved chunk. While this happens in the
general case as well, it will only fail if it cannot allocate a new
chunk.

This patch resets the block offset to 0 to pass the second predicate
when checking subseqent blocks within the iterator function.

Signed-off-by: Dennis Zhou <dennisszhou@gmail.com>
Reported-by: Luis Henriques <lhenriques@suse.com>
---
 mm/percpu.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mm/percpu.c b/mm/percpu.c
index 59d44d6..aa121ce 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -353,6 +353,8 @@ static void pcpu_next_md_free_region(struct pcpu_chunk *chunk, int *bit_off,
 					block->contig_hint_start);
 			return;
 		}
+		/* reset to satisfy the second predicate above */
+		block_off = 0;
 
 		*bits = block->right_free;
 		*bit_off = (i + 1) * PCPU_BITMAP_BLOCK_BITS - block->right_free;
@@ -407,6 +409,8 @@ static void pcpu_next_fit_region(struct pcpu_chunk *chunk, int alloc_bits,
 			*bit_off = pcpu_block_off_to_off(i, block->first_free);
 			return;
 		}
+		/* reset to satisfy the second predicate above */
+		block_off = 0;
 
 		*bit_off = ALIGN(PCPU_BITMAP_BLOCK_BITS - block->right_free,
 				 align);
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] percpu: fix block iterators and reserved chunk stats Dennis Zhou <dennisszhou@gmail.com> - 2017-09-27 23:40 +0200
  [PATCH 2/2] percpu: fix iteration to prevent skipping over block Dennis Zhou <dennisszhou@gmail.com> - 2017-09-27 23:40 +0200
    Re: [PATCH 2/2] percpu: fix iteration to prevent skipping over block Tejun Heo <tj@kernel.org> - 2017-09-28 00:00 +0200
      Re: [PATCH 2/2] percpu: fix iteration to prevent skipping over block Luis Henriques <lhenriques@suse.com> - 2017-09-28 10:40 +0200
    Re: [PATCH 2/2] percpu: fix iteration to prevent skipping over block Tejun Heo <tj@kernel.org> - 2017-09-28 16:50 +0200
  [PATCH 1/2] percpu: fix starting offset for chunk statistics traversal Dennis Zhou <dennisszhou@gmail.com> - 2017-09-27 23:40 +0200
    Re: [PATCH 1/2] percpu: fix starting offset for chunk statistics  traversal Tejun Heo <tj@kernel.org> - 2017-09-27 23:50 +0200

csiph-web