Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel panic

From	"Yang Shi" <yang.s@alibaba-inc.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel panic
Date	2017-09-27 19:30 +0200
Message-ID	<uuojM-63X-11@gated-at.bofh.it> (permalink)
References	<uu8RH-3yU-3@gated-at.bofh.it> <uu8RI-3yU-17@gated-at.bofh.it> <uueNr-7BL-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 9/27/17 12:14 AM, Christopher Lameter wrote:
> On Wed, 27 Sep 2017, Yang Shi wrote:
> 
>> Print out unreclaimable slab info (used size and total size) which
>> actual memory usage is not zero (num_objs * size != 0) when:
>>    - unreclaimable slabs : all user memory > unreclaim_slabs_oom_ratio
>>    - panic_on_oom is set or no killable process
> 
> Ok. I like this much more than the earlier releases.
> 
>> diff --git a/mm/slab.h b/mm/slab.h
>> index 0733628..b0496d1 100644
>> --- a/mm/slab.h
>> +++ b/mm/slab.h
>> @@ -505,6 +505,14 @@ static inline struct kmem_cache_node *get_node(struct kmem_cache *s, int node)
>>   void memcg_slab_stop(struct seq_file *m, void *p);
>>   int memcg_slab_show(struct seq_file *m, void *p);
>>
>> +#ifdef CONFIG_SLABINFO
>> +void dump_unreclaimable_slab(void);
>> +#else
>> +static inline void dump_unreclaimable_slab(void)
>> +{
>> +}
>> +#endif
> 
> CONFIG_SLABINFO? How does this relate to the oom info? /proc/slabinfo
> support is optional. Oom info could be included even if CONFIG_SLABINFO
> goes away. Remove the #ifdef?

Because we want to dump the unreclaimable slab info in oom info.

Thanks,
Yang

>

Thread

[PATCH 0/3 v7] oom: capture unreclaimable slab info in oom message when kernel panic "Yang Shi" <yang.s@alibaba-inc.com> - 2017-09-27 03:00 +0200
  [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel panic "Yang Shi" <yang.s@alibaba-inc.com> - 2017-09-27 03:00 +0200
    Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic Christopher Lameter <cl@linux.com> - 2017-09-27 09:20 +0200
      Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic "Yang Shi" <yang.s@alibaba-inc.com> - 2017-09-27 19:30 +0200
        Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic Christopher Lameter <cl@linux.com> - 2017-09-28 00:00 +0200
          Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic "Yang Shi" <yang.s@alibaba-inc.com> - 2017-09-28 00:20 +0200
            Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic Christopher Lameter <cl@linux.com> - 2017-10-01 08:50 +0200
              Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic "Yang Shi" <yang.s@alibaba-inc.com> - 2017-10-02 22:50 +0200
    Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic Michal Hocko <mhocko@kernel.org> - 2017-09-27 12:50 +0200
      Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic "Yang Shi" <yang.s@alibaba-inc.com> - 2017-09-27 19:30 +0200
        Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic Michal Hocko <mhocko@kernel.org> - 2017-10-02 09:30 +0200
          Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel  panic "Yang Shi" <yang.s@alibaba-inc.com> - 2017-10-02 22:50 +0200

csiph-web