Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling
Date	2017-09-27 18:50 +0200
Message-ID	<uunH5-5Cm-19@gated-at.bofh.it> (permalink)
References	<ukwLD-5Ay-3@gated-at.bofh.it> <ukwLD-5Ay-1@gated-at.bofh.it> <utZEL-6pY-53@gated-at.bofh.it> <uulvA-4kL-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 27, 2017 at 04:22:39PM +0200, Anna-Maria Gleixner wrote:
> I know and Thomas was unhappy about that as well, but we did not come
> up with a better solution.
> 
> The nasty alternative is:
> 
> static void __run_hrtimer(struct hrtimer_cpu_base *cpu_base,
> 			  struct hrtimer_clock_base *base,
> -			  struct hrtimer *timer, ktime_t *now)
> +			  struct hrtimer *timer, ktime_t *now,
> +                   	  unsigned long flags)
> ...
> -	raw_spin_unlock(&cpu_base->lock);
> +	raw_spin_unlock_irqrestore(&cpu_base->lock, flags);
> 
> ...
> -	raw_spin_lock(&cpu_base->lock);
> +	raw_spin_lock_irq(&cpu_base->lock, flags);
> 
> and hand in flags from the callsites via local_save_flags().

Just push it up one more level and use raw_spin_lock_irqsave() in the
(soft)irq handlers and then pass the flags around.

Thta's what I did in that patch I just send.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer  handling Anna-Maria Gleixner <anna-maria@linutronix.de> - 2017-09-27 16:30 +0200
  Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling Peter Zijlstra <peterz@infradead.org> - 2017-09-27 18:50 +0200

csiph-web