Re: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling notifications

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling notifications
Date	2017-09-27 17:50 +0200
Message-ID	<uumL0-51X-13@gated-at.bofh.it> (permalink)
References	<usabf-1IE-3@gated-at.bofh.it> <usabh-1IE-33@gated-at.bofh.it> <utE7g-fi-5@gated-at.bofh.it> <utI1c-2RB-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 25, 2017 at 08:14:00PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@gmail.com]
> > Sent: Monday, September 25, 2017 12:04 PM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: dvhart@infradead.org; LKML <linux-kernel@vger.kernel.org>; platform-driver-
> > x86@vger.kernel.org; quasisec@google.com
> > Subject: Re: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling
> > notifications
> > 
> > On Thursday 21 September 2017 08:57:06 Mario Limonciello wrote:
> > > This driver serves the purpose of responding to WMI based notifications
> > > from the DELL_EVENT_GUID (9DBB5994-A997-11DA-B012-B622A1EF5492).
> > > Other GUIDs will be handled by separate drivers.
> > >
> > > Update the language used by this driver to avoid future confusion.
> > 
> > Hi! I'm not sure if if "notifications" word is better then "extras".
> > Basically the most important part of the dell-wmi driver is to deliver
> > key press events via input device.
> > 
> > Has anybody else better word or description for this?
> > 
> I was actually tempted to rename the driver itself to dell-wmi-notifications.
> Realistically it is hooking up to the notifications _WED0 AML method so yes
> it is picking up notifications exclusively.
> 
> I thought about this too, but I can also envision that the notifications that
> come through this driver that aren't consumed by the kernel for keypress
> purposes are also useful to user space potentially.  It's not part of this series
> but maybe in the future providing those through a character device too may
> make sense.

Naming is hard, but this seems like a reasonable refinement without
over-specifying.

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling  notifications Darren Hart <dvhart@infradead.org> - 2017-09-27 17:50 +0200

csiph-web