Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740763

Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

Show all headers | View raw

Hi Corentin

> +Required properties for the mdio-mux node:
> +  - compatible = "mdio-mux"

This is too generic. Please add a more specific compatible for this
particular mux. You can keep "mdio-mux", since that is what the MDIO
subsystem will look for.

> +Required properties of the integrated phy node:
>  - clocks: a phandle to the reference clock for the EPHY
>  - resets: a phandle to the reset control for the EPHY
> +- phy-is-integrated

So the last thing you said is that the mux is not the problem
here. Something else is locking up. Did you discover what?

I really would like phy-is-integrated to go away.

  Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 00/11] net: stmmac: dwmac-sun8i: Handle integrated PHY Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 02/11] arm: dts: sunxi: Restore EMAC changes Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 09/11] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 03/11] arm64: dts: allwinner: Restore EMAC changes Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 10/11] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
    Re: [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from  scanning mdio-mux nodes Andrew Lunn <andrew@lunn.ch> - 2017-09-27 16:20 +0200
      Re: [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from  scanning mdio-mux nodes Florian Fainelli <f.fainelli@gmail.com> - 2017-09-28 07:00 +0200
  [PATCH v6 07/11] arm64: dts: allwinner: add snps,dwmac-mdio compatible to emac/mdio Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 04/11] net: stmmac: sun8i: Restore the compatibles Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
    Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update  documentation about integrated PHY Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-27 12:20 +0200
    Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update  documentation about integrated PHY Andrew Lunn <andrew@lunn.ch> - 2017-09-27 16:10 +0200
      Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update  documentation about integrated PHY Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-28 09:40 +0200
    Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update  documentation about integrated PHY Florian Fainelli <f.fainelli@gmail.com> - 2017-09-28 07:00 +0200
      Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update  documentation about integrated PHY Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-28 09:10 +0200
  [PATCH v6 08/11] net: stmmac: snps,dwmac-mdio MDIOs are automatically registered Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:40 +0200
  [PATCH v6 01/11] dt-bindings: net: Restore sun8i dwmac binding Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-27 09:50 +0200

csiph-web