Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1740718

Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty

From Eric Dumazet <edumazet@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty
Date 2017-09-27 15:30 +0200
Message-ID <uukzw-3iO-29@gated-at.bofh.it> (permalink)
References <uujtN-2gN-33@gated-at.bofh.it> <uujWO-2Bu-15@gated-at.bofh.it> <uujWP-2Bu-25@gated-at.bofh.it> <uuk6v-2Hs-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Sep 27, 2017 at 5:58 AM, Alexander Potapenko <glider@google.com> wrote:
> On Wed, Sep 27, 2017 at 2:45 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Wed, 2017-09-27 at 05:42 -0700, Eric Dumazet wrote:
>>
>>> Or something cleaner to avoid copy/paste and focus on proper
>>> skb->data[0] access and meaning.
> By the way I'm wondering if this is the only place where skb->data is
> being accessed.
> Isn't eth_type_trans() under IFF_TAP also touching it? Then we need to
> check the size earlier.

It is already checked.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] tun: bail out from tun_get_user() if the skb is empty Alexander Potapenko <glider@google.com> - 2017-09-27 14:20 +0200
  Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty Eric Dumazet <eric.dumazet@gmail.com> - 2017-09-27 14:50 +0200
    Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty Eric Dumazet <eric.dumazet@gmail.com> - 2017-09-27 14:50 +0200
      Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty Alexander Potapenko <glider@google.com> - 2017-09-27 15:00 +0200
        Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty Eric Dumazet <edumazet@google.com> - 2017-09-27 15:30 +0200
          Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty Alexander Potapenko <glider@google.com> - 2017-09-27 16:40 +0200

csiph-web