Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740704

[PATCH] uio/uio_pci_generic: Add SR-IOV support

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

From: David Woodhouse <dwmw@amazon.co.uk>

Allow userspace to configure SR-IOV VFs through sysfs.

Currently, we need an in-kernel driver to permit this. But sometimes
*all* we want to do is enable the VFs so that we can assign them to
guests; we don't actually need to deal with the PF in any other way
from the host kernel. So let's make it possible to use UIO for that.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
It's not entirely clear to me why we require the driver to "enable"
SR-IOV like this anyway — were there some which needed to do something
special and device-specific instead of just falling through to
pci_{en,dis}able_sriov(), such that we need to effectively whitelist
this in the driver rather than blacklisting the "problematic" ones via
PCI quirks?

 drivers/uio/uio_pci_generic.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index a56fdf9..bd196f0 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b/drivers/uio/uio_pci_generic.c
@@ -108,15 +108,27 @@ static void remove(struct pci_dev *pdev)
 	struct uio_pci_generic_dev *gdev = pci_get_drvdata(pdev);
 
 	uio_unregister_device(&gdev->info);
+	pci_disable_sriov(pdev);
 	pci_disable_device(pdev);
 	kfree(gdev);
 }
 
+static int sriov_configure(struct pci_dev *pdev, int num_vfs)
+{
+	if (!num_vfs) {
+		pci_disable_sriov(pdev);
+		return 0;
+	}
+
+	return pci_enable_sriov(pdev, num_vfs);
+}
+
 static struct pci_driver uio_pci_driver = {
 	.name = "uio_pci_generic",
 	.id_table = NULL, /* only dynamic id's */
 	.probe = probe,
 	.remove = remove,
+	.sriov_configure = sriov_configure,
 };
 
 module_pci_driver(uio_pci_driver);
-- 
2.7.4

-- 
dwmw2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] uio/uio_pci_generic: Add SR-IOV support David Woodhouse <dwmw2@infradead.org> - 2017-09-27 15:20 +0200
  Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support Bjorn Helgaas <helgaas@kernel.org> - 2017-09-28 00:10 +0200
    Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support David Woodhouse <dwmw2@infradead.org> - 2017-09-28 00:30 +0200
      Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support Alexander Duyck <alexander.duyck@gmail.com> - 2017-09-28 01:10 +0200
        Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support Don Dutile <ddutile@redhat.com> - 2017-09-28 14:30 +0200
          Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support David Woodhouse <dwmw2@infradead.org> - 2017-09-28 15:50 +0200
            Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support Don Dutile <ddutile@redhat.com> - 2017-09-28 17:10 +0200
              Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support David Woodhouse <dwmw2@infradead.org> - 2017-09-28 18:00 +0200
                Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support Don Dutile <ddutile@redhat.com> - 2017-09-28 19:00 +0200
                Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support David Woodhouse <dwmw2@infradead.org> - 2017-10-02 14:40 +0200
                Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support Don Dutile <ddutile@redhat.com> - 2017-10-02 22:50 +0200
    Re: [PATCH] uio/uio_pci_generic: Add SR-IOV support Don Dutile <ddutile@redhat.com> - 2017-09-28 14:20 +0200

csiph-web