Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1740743

Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding
Date 2017-09-27 15:50 +0200
Message-ID <uukST-3A0-25@gated-at.bofh.it> (permalink)
References <uuaA9-4NP-9@gated-at.bofh.it> <uuaA9-4NP-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Sep 27, 2017 at 4:45 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> This GPIO controller is used on UniPhier SoC family.
>
> The vendor specific property "socionext,interrupt-ranges" is for
> specifying interrupt mapping to the parent interrupt controller
> because the mapping is not contiguous.  It works like "ranges",
> but transforms "interrupts" instead of "reg".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Rob Herring <robh@kernel.org>

I don't think Rob has seen the new interrupt range thing?
(It's not a big deal. Things like these are a bit fuzzy.)

> +               socionext,interrupt-ranges = <0 48 16>, <16 154 5>, <21 217 3>;

If it is as you say, that other SoCs are doing the same, we should
think about creating a generic property for this. Like
hierarchy-interrupt-ranges or so.

I kind of liked the old patch where it was just "interrupts" and
then you looked it up from the irq subsystem. (tglx even ACKed
the patch).

But I want the DT people to say something here.

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-27 04:50 +0200
  Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding Linus Walleij <linus.walleij@linaro.org> - 2017-09-27 15:50 +0200
    Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-27 16:50 +0200

csiph-web