Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741945

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

Show all headers | View raw

On 09/28/2017 11:29 PM, Andrew Morton wrote:
> On Thu, 28 Sep 2017 14:11:41 +0800 Kemi Wang <kemi.wang@intel.com> wrote:
> 
>> This is the second step which introduces a tunable interface that allow
>> numa stats configurable for optimizing zone_statistics(), as suggested by
>> Dave Hansen and Ying Huang.
> 
> Looks OK I guess.
> 
> I fiddled with it a lot.  Please consider:
> 
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-sysctl-make-numa-stats-configurable-fix
> 
> - tweak documentation
> 
> - move advisory message from start_kernel() into mm_init() (I'm not sure
>   we really need this message)

Actually, I'm not sure we need any of the current messages, or to have
them at higher priority than pr_debug()? They are all triggered by admin
action, or unconditionally upon boot.
OTOH I think that an useful message that's currently missing would be
when the static_key_enable() is triggered in auto mode. Bonus points for
including the name of the process and the stat file that was read.
However static_key_enable() returns void and not whether it actually
flipped the switch, so it's not trivial.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] mm, sysctl: make NUMA stats configurable Kemi Wang <kemi.wang@intel.com> - 2017-09-28 08:20 +0200
  Re: [PATCH v3] mm, sysctl: make NUMA stats configurable Andrew Morton <akpm@linux-foundation.org> - 2017-09-28 23:40 +0200
    Re: [PATCH v3] mm, sysctl: make NUMA stats configurable kemi <kemi.wang@intel.com> - 2017-09-29 03:50 +0200
    Re: [PATCH v3] mm, sysctl: make NUMA stats configurable Vlastimil Babka <vbabka@suse.cz> - 2017-09-29 09:10 +0200
  Re: [PATCH v3] mm, sysctl: make NUMA stats configurable Vlastimil Babka <vbabka@suse.cz> - 2017-09-29 09:10 +0200
  Re: [PATCH v3] mm, sysctl: make NUMA stats configurable Vlastimil Babka <vbabka@suse.cz> - 2017-09-29 09:30 +0200

csiph-web