Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function

From	"Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function
Date	2017-09-29 04:10 +0200
Message-ID	<uuSUx-8te-9@gated-at.bofh.it> (permalink)
References	<uuyCt-49t-3@gated-at.bofh.it> <uuyMa-4cw-33@gated-at.bofh.it> <uuHw5-1ff-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2017/9/28 21:50, Leon Romanovsky wrote:
> On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote:
>> From: Lijun Ou <oulijun@huawei.com>
>>
>> It mainly places the lines for checking send doorbell status
>> into a special functions. As a result, we can directly call it in
>> check_qp_db_process_status function and keep consistent indenting
>> style.
>>
>> It fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style)
> You forgot " at the end of the line, and there is need to put fixes
> (should be Fixes) in the line before Signed-off-by.
Thanks, Leon
We will modify the statement(Fixes: xx)  and put it before signed-off-by 
in patch v2.

>> The warning from static checker:
>> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status()
>> warn: inconsistent indenting
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Shaobo Xu <xushaobo2@huawei.com>
>> ---
>>   drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 95 ++++++++++++++++--------------
>>   1 file changed, 51 insertions(+), 44 deletions(-)
>>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH for-next 0/9] Bug fixes & Code improvements in hip06 and hip08 RoCE driver "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-28 06:40 +0200
  [PATCH for-next 7/9] RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-28 06:40 +0200
  [PATCH for-next 6/9] RDMA/hns: Add return statement when checking error in hns_roce_v1_mr_free_work_fn "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-28 06:40 +0200
  [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-28 06:40 +0200
    Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking  sdb status into a new function Leon Romanovsky <leon@kernel.org> - 2017-09-28 16:00 +0200
      Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking  sdb status into a new function "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-29 04:10 +0200

csiph-web