Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741692

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule be Tasks RCU quiescent state
Date 2017-09-28 18:20 +0200
Message-ID <uuJHA-2JP-17@gated-at.bofh.it> (permalink)
References (1 earlier) <ty17r-5PA-9@gated-at.bofh.it> <uuDsv-7h4-21@gated-at.bofh.it> <uuGgG-yM-15@gated-at.bofh.it> <uuJey-2kP-13@gated-at.bofh.it> <uuJxV-2Gx-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 28, 2017 at 09:05:14AM -0700, Paul E. McKenney wrote:
> >  do_async_page_fault+0x72/0x90 arch/x86/kernel/kvm.c:271
> >  async_page_fault+0x22/0x30 arch/x86/entry/entry_64.S:1069
> > RIP: 0010:format_decode+0x240/0x830 lib/vsprintf.c:1996
> > RSP: 0018:ffff88003b2df520 EFLAGS: 00010283
> > RAX: 000000000000003f RBX: ffffffffb5d1e141 RCX: ffff88003b2df670
> > RDX: 0000000000000001 RSI: dffffc0000000000 RDI: ffffffffb5d1e140
> > RBP: ffff88003b2df560 R08: dffffc0000000000 R09: 0000000000000000
> > R10: ffff88003b2df718 R11: 0000000000000000 R12: ffff88003b2df5d8
> > R13: 0000000000000064 R14: ffffffffb5d1e140 R15: 0000000000000000
> >  vsnprintf+0x173/0x1700 lib/vsprintf.c:2136
> 
> We took a page fault in vsnprintf() while doing link_path_walk(),
> which looks to be within an RCU read-side critical section.
> 
> Maybe the page fault confused lockdep?
> 
> Sigh.  It is going to be a real pain if all printk()s need to be
> outside of RCU read-side critical sections due to the possibility of
> page faults...

printk() _should_ not fault AFAIK. If it does, you've done something
dodgy.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Sasha Levin <levinsasha928@gmail.com> - 2017-09-28 11:40 +0200
  Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-28 14:40 +0200
    Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-28 17:50 +0200
      Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Peter Zijlstra <peterz@infradead.org> - 2017-09-28 18:10 +0200
        Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-28 18:30 +0200
      Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-28 18:10 +0200
        Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Peter Zijlstra <peterz@infradead.org> - 2017-09-28 18:20 +0200
          Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-28 18:40 +0200
        Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Boqun Feng <boqun.feng@gmail.com> - 2017-09-29 11:40 +0200
          Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Paolo Bonzini <pbonzini@redhat.com> - 2017-09-29 12:10 +0200
            Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Boqun Feng <boqun.feng@gmail.com> - 2017-09-29 12:30 +0200
            Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Peter Zijlstra <peterz@infradead.org> - 2017-09-29 12:40 +0200
              Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state Paolo Bonzini <pbonzini@redhat.com> - 2017-09-29 13:50 +0200
                Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-29 19:00 +0200
            Re: [PATCH v3 tip/core/rcu 40/40] rcu: Make non-preemptive schedule  be Tasks RCU quiescent state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-29 19:00 +0200

csiph-web