Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1741621
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 |
| Date | 2017-09-28 17:20 +0200 |
| Message-ID | <uuILw-2bi-29@gated-at.bofh.it> (permalink) |
| References | <uuDiN-7d1-3@gated-at.bofh.it> <uuDiO-7d1-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi,
On Thu, Sep 28, 2017 at 09:25:41AM +0000, Icenowy Zheng wrote:
> + /*
> + * The max-frequency properties in all MMC controller nodes
> + * are conservative values proven to work on Banana Pi M2
> + * Ultra (the first community available R40 board).
> + * As the board doesn't wire MMC3 out, the property is not
> + * set in MMC3.
> + * TODO: measure the accurate max frequency of the controllers.
> + */
> + mmc0: mmc@1c0f000 {
> + compatible = "allwinner,sun8i-r40-mmc",
> + "allwinner,sun50i-a64-mmc";
> + reg = <0x01c0f000 0x1000>;
> + clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>;
> + clock-names = "ahb", "mmc";
> + resets = <&ccu RST_BUS_MMC0>;
> + reset-names = "ahb";
> + pinctrl-0 = <&mmc0_pins>;
> + pinctrl-names = "default";
> + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> + max-frequency = <25000000>;
> + status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
Sorry if it wasn't really clear, but my point was more than you should
just drop the max-frequency property
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Icenowy Zheng <icenowy@aosc.io> - 2017-09-28 11:30 +0200
Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-28 17:20 +0200
Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Icenowy Zheng <icenowy@aosc.io> - 2017-09-29 12:30 +0200
Re: [linux-sunxi] Re: [PATCH v2 1/3] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Chen-Yu Tsai <wens@csie.org> - 2017-09-29 12:40 +0200
csiph-web