Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id
Date	2017-09-28 17:20 +0200
Message-ID	<uuILw-2bi-19@gated-at.bofh.it> (permalink)
References	<uuojM-63X-15@gated-at.bofh.it> <uuufw-1dY-9@gated-at.bofh.it> <uuuyR-1zn-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Wed, Sep 27, 2017 at 5:07 PM, Grant Grundler <grundler@chromium.org> wrote:
>>>  #define DELL_VENDOR_ID         0x413C
>>>  #define REALTEK_VENDOR_ID      0x0bda
>>>  #define SAMSUNG_VENDOR_ID      0x04e8
>>> +#define LINKSYS_VENDOR_ID      0x13b1
>>>  #define LENOVO_VENDOR_ID       0x17ef
>>
>> Slight nit that "LI" sorts after "LE".  You got it right in the other case...
>
> The list isn't sorted by any rational thing I can see.  I managed to
> check my OCD reaction to sort the list numerically. :)

Whoops, you're right.  It seems to be in a random order.  I just saw
LE, LI, and N sorted properly and jumped to a conclusion.  In any
case, if it's all the same to you it'd be nice if you were consistent
between LENOVO/LINKSYS in the two files.  :-P

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] r8152:  add Linksys USB3GIGV1 id Grant Grundler <grundler@chromium.org> - 2017-09-27 19:30 +0200
  Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id Doug Anderson <dianders@chromium.org> - 2017-09-28 01:50 +0200
    Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id Grant Grundler <grundler@chromium.org> - 2017-09-28 02:10 +0200
      Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id Doug Anderson <dianders@chromium.org> - 2017-09-28 17:20 +0200

csiph-web