Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1741472
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: sched: serial port lockdep warning when offlining CPUs |
| Date | 2017-09-28 14:00 +0200 |
| Message-ID | <uuFDX-8w4-15@gated-at.bofh.it> (permalink) |
| References | <uuDiO-7d1-15@gated-at.bofh.it> <uuDsv-7h4-19@gated-at.bofh.it> <uuEoy-7PA-17@gated-at.bofh.it> <uuFuh-8sU-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On (09/28/17 13:47), Peter Zijlstra wrote:
> On Thu, Sep 28, 2017 at 07:30:32PM +0900, Sergey Senozhatsky wrote:
> > ---
> >
> > lib/ratelimit.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/ratelimit.c b/lib/ratelimit.c
> > index 08f8043cac61..bddc55834c2e 100644
> > --- a/lib/ratelimit.c
> > +++ b/lib/ratelimit.c
> > @@ -48,7 +48,8 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
> > if (time_is_before_jiffies(rs->begin + rs->interval)) {
> > if (rs->missed) {
> > if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
> > - pr_warn("%s: %d callbacks suppressed\n", func, rs->missed);
> > + printk_deferred(KERN_WARN "%s: %d callbacks suppressed\n",
> > + func, rs->missed);
> > rs->missed = 0;
> > }
> > }
>
> Oh cute; I figured it was the syslog daemon suppressing multiple
> identical lines, but yes the above looks very plausible.
seems to be stable v4.8+ material.
Fixes: 6b1d174b0c27b ("ratelimit: extend to print suppressed messages on release")
I'll send out a patch.
-ss
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
sched: serial port lockdep warning when offlining CPUs Sasha Levin <levinsasha928@gmail.com> - 2017-09-28 11:30 +0200
Re: sched: serial port lockdep warning when offlining CPUs Peter Zijlstra <peterz@infradead.org> - 2017-09-28 11:40 +0200
Re: sched: serial port lockdep warning when offlining CPUs Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-28 12:40 +0200
Re: sched: serial port lockdep warning when offlining CPUs Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-28 13:40 +0200
Re: sched: serial port lockdep warning when offlining CPUs "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-28 14:00 +0200
Re: sched: serial port lockdep warning when offlining CPUs Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-28 14:00 +0200
Re: sched: serial port lockdep warning when offlining CPUs Peter Zijlstra <peterz@infradead.org> - 2017-09-28 14:10 +0200
Re: sched: serial port lockdep warning when offlining CPUs Peter Zijlstra <peterz@infradead.org> - 2017-09-28 14:10 +0200
Re: sched: serial port lockdep warning when offlining CPUs Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-28 14:20 +0200
Re: sched: serial port lockdep warning when offlining CPUs Peter Zijlstra <peterz@infradead.org> - 2017-09-28 14:30 +0200
Re: sched: serial port lockdep warning when offlining CPUs Peter Zijlstra <peterz@infradead.org> - 2017-09-28 13:50 +0200
Re: sched: serial port lockdep warning when offlining CPUs Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-28 14:00 +0200
Re: sched: serial port lockdep warning when offlining CPUs "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-28 13:10 +0200
Re: sched: serial port lockdep warning when offlining CPUs Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-28 13:20 +0200
Re: sched: serial port lockdep warning when offlining CPUs Peter Zijlstra <peterz@infradead.org> - 2017-09-28 13:40 +0200
csiph-web