Re: [PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor
Date	2017-09-28 10:20 +0200
Message-ID	<uuCd4-6xg-13@gated-at.bofh.it> (permalink)
References	<ut9Zw-5Xi-7@gated-at.bofh.it> <ut9Zw-5Xi-9@gated-at.bofh.it> <uusno-8uO-19@gated-at.bofh.it> <uuCd4-6xg-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Leon,

On Wed, Sep 27, 2017 at 11:48:21PM -0700, Leon Luo wrote:
> Hi Sakari,
> 
> Thanks for your comments.
> 
> Regarding imx274_tp_regs[], the first value is the test pattern mode, which
> will be updated according to the input value before writing the register.
> So it can't be a const.

In that case you'll need to explicitly write that register; this is
specific to a device whereas the static variable is the same for all
devices.

> 
> I will use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to keep the
> lock/unlock mutex clean. I am traveling right now, will test it and send a
> new patch this weekend.

Ack.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS  sensor Sakari Ailus <sakari.ailus@iki.fi> - 2017-09-28 10:20 +0200

csiph-web