Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling
Date	2017-09-28 10:20 +0200
Message-ID	<uuCd3-6xg-1@gated-at.bofh.it> (permalink)
References	<ukwLD-5Ay-3@gated-at.bofh.it> <ukwLD-5Ay-1@gated-at.bofh.it> <uunH4-5Cm-9@gated-at.bofh.it> <uuC3o-6tW-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 28, 2017 at 09:59:50AM +0200, Thomas Gleixner wrote:
> On Wed, 27 Sep 2017, Peter Zijlstra wrote:
> > On Thu, Aug 31, 2017 at 12:23:42PM -0000, Anna-Maria Gleixner wrote:
> >  static void __run_hrtimer(struct hrtimer_cpu_base *cpu_base,
> >  			  struct hrtimer_clock_base *base,
> >  			  struct hrtimer *timer, ktime_t *now,
> > -			  bool hardirq)
> > +			  unsigned long flags)
> >  {
> >  	enum hrtimer_restart (*fn)(struct hrtimer *);
> >  	int restart;
> > @@ -1298,19 +1323,13 @@ static void __run_hrtimer(struct hrtimer
> >  	 * protected against migration to a different CPU even if the lock
> >  	 * is dropped.
> >  	 */
> > -	if (hardirq)
> > -		raw_spin_unlock(&cpu_base->lock);
> > -	else
> > -		raw_spin_unlock_irq(&cpu_base->lock);
> > +	raw_spin_unlock_irqrestore(&cpu_base->lock, flags);
> >  
> >  	trace_hrtimer_expire_entry(timer, now);
> >  	restart = fn(timer);
> >  	trace_hrtimer_expire_exit(timer);
> >  
> > -	if (hardirq)
> > -		raw_spin_lock(&cpu_base->lock);
> > -	else
> > -		raw_spin_lock_irq(&cpu_base->lock);
> > +	raw_spin_lock_irqsave(&cpu_base->lock, flags);
> 
> No point in irqsave() here. _irq() is sufficient as we leave the function
> right after that.

True, I wasn't entirely sure on the irq tracing assumptions (if any) and
was too lazy to double check.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling Peter Zijlstra <peterz@infradead.org> - 2017-09-27 18:50 +0200
  Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer  handling Thomas Gleixner <tglx@linutronix.de> - 2017-09-28 10:10 +0200
    Re: [PATCH 17/25] hrtimer: Implementation of softirq hrtimer handling Peter Zijlstra <peterz@infradead.org> - 2017-09-28 10:20 +0200

csiph-web