Re: [PATCH] x86/setup: Clarify a comment

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/setup: Clarify a comment
Date	2017-09-28 09:50 +0200
Message-ID	<uuBK2-68e-7@gated-at.bofh.it> (permalink)
References	<urpYJ-5sW-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Jean Delvare <jdelvare@suse.de> wrote:

> It's not obvious to everybody that BP stands for boot processor. At
> least it was not for me.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Alok Kataria <akataria@vmware.com>
> ---
>  arch/x86/kernel/setup.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-4.14-rc1.orig/arch/x86/kernel/setup.c	2017-09-17 00:47:51.000000000 +0200
> +++ linux-4.14-rc1/arch/x86/kernel/setup.c	2017-09-19 14:28:30.553830299 +0200
> @@ -1045,7 +1045,7 @@ void __init setup_arch(char **cmdline_p)
>  
>  	/*
>  	 * VMware detection requires dmi to be available, so this
> -	 * needs to be done after dmi_scan_machine, for the BP.
> +	 * needs to be done after dmi_scan_machine, for the boot processor.
>  	 */
>  	init_hypervisor_platform();

Ok, I agree with this change - but there's a couple of other references to 'BP' in 
the x86 code, if then we should change all of them over to 'boot CPU'.

Also, while at it, please change 'dmi_scan_machine' to 'dmi_scan_machine()', which 
is the canonical way to refer to function calls.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] x86/setup: Clarify a comment Ingo Molnar <mingo@kernel.org> - 2017-09-28 09:50 +0200

csiph-web