Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740343

Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB DMA controller

From Dmitry Osipenko <digetx@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB DMA controller
Date 2017-09-27 04:00 +0200
Message-ID <uu9NN-4b6-15@gated-at.bofh.it> (permalink)
References <utKZ3-4P8-5@gated-at.bofh.it> <utKZ4-4P8-31@gated-at.bofh.it> <utZv3-66l-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 26.09.2017 17:50, Jon Hunter wrote:
> 
> On 26/09/17 00:22, Dmitry Osipenko wrote:
>> Document DT bindings for NVIDIA Tegra AHB DMA controller that presents
>> on Tegra20/30 SoC's.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  .../bindings/dma/nvidia,tegra20-ahbdma.txt         | 23 ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt
>>
>> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt b/Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt
>> new file mode 100644
>> index 000000000000..2af9aa76ae11
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt
>> @@ -0,0 +1,23 @@
>> +* NVIDIA Tegra AHB DMA controller
>> +
>> +Required properties:
>> +- compatible:	Must be "nvidia,tegra20-ahbdma"
>> +- reg:		Should contain registers base address and length.
>> +- interrupts:	Should contain one entry, DMA controller interrupt.
>> +- clocks:	Should contain one entry, DMA controller clock.
>> +- resets :	Should contain one entry, DMA controller reset.
>> +- #dma-cells:	Should be <1>. The cell represents DMA request select value
>> +		for the peripheral. For more details consult the Tegra TRM's
>> +		documentation, in particular AHB DMA channel control register
>> +		REQ_SEL field.
> 
> What about the TRIG_SEL field? Do we need to handle this here as well?
> 

Actually, DMA transfer trigger isn't related a hardware description. It's up to
software to decide what trigger to select. So it shouldn't be in the binding.

And I think the same applies to requester... any objections?

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/5] NVIDIA Tegra AHB DMA controller driver Dmitry Osipenko <digetx@gmail.com> - 2017-09-26 01:30 +0200
  [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB DMA controller Dmitry Osipenko <digetx@gmail.com> - 2017-09-26 01:30 +0200
    Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Jon Hunter <jonathanh@nvidia.com> - 2017-09-26 17:00 +0200
      Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Dmitry Osipenko <digetx@gmail.com> - 2017-09-26 17:20 +0200
      Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Dmitry Osipenko <digetx@gmail.com> - 2017-09-27 04:00 +0200
        Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Jon Hunter <jonathanh@nvidia.com> - 2017-09-27 10:40 +0200
          Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Dmitry Osipenko <digetx@gmail.com> - 2017-09-27 14:20 +0200
            Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Jon Hunter <jonathanh@nvidia.com> - 2017-09-27 15:50 +0200
              Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Jon Hunter <jonathanh@nvidia.com> - 2017-09-27 15:50 +0200
                Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Dmitry Osipenko <digetx@gmail.com> - 2017-09-27 16:30 +0200
          Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Stephen Boyd <sboyd@codeaurora.org> - 2017-09-28 01:40 +0200
            Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Jon Hunter <jonathanh@nvidia.com> - 2017-09-28 10:40 +0200
          Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Stephen Warren <swarren@wwwdotorg.org> - 2017-09-29 21:40 +0200
            Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Dmitry Osipenko <digetx@gmail.com> - 2017-09-30 05:20 +0200
              Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB  DMA controller Stephen Warren <swarren@wwwdotorg.org> - 2017-10-02 22:50 +0200
  Re: [PATCH v1 0/5] NVIDIA Tegra AHB DMA controller driver Vinod Koul <vinod.koul@intel.com> - 2017-09-28 11:30 +0200
    Re: [PATCH v1 0/5] NVIDIA Tegra AHB DMA controller driver Dmitry Osipenko <digetx@gmail.com> - 2017-09-28 14:30 +0200

csiph-web