Re: BUG in git diff-index

From	Marc Herbert <Marc.Herbert@intel.com>
Newsgroups	linux.kernel
Subject	Re: BUG in git diff-index
Date	2017-09-26 21:50 +0200
Message-ID	<uu41J-zi-29@gated-at.bofh.it> (permalink)
References	(1 earlier) <uu41J-zi-33@gated-at.bofh.it> <uu41J-zi-35@gated-at.bofh.it> <uu41J-zi-37@gated-at.bofh.it> <uu41J-zi-39@gated-at.bofh.it> <uu41J-zi-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 31/03/16 13:39, Junio C Hamano wrote:
> Andy Lowry <andy.work@nglowry.com> writes:
> 
>> So I think now that the script should do "update-index --refresh"
>> followed by "diff-index --quiet HEAD". Sound correct?
> 
> Yes.  That has always been one of the kosher ways for any script to
> make sure that the files in the working tree that are tracked have
> not been modified relative to HEAD (assuming that the index matches
> HEAD).  

Too bad kernel/scripts/setlocalversion didn't get the memo:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cdf2bc632ebc9ef51
> scripts/setlocalversion on write-protected source tree (2013)
> I don't see how removing "git update-index" could do any harm.

This causes a spurious "-dirty" suffix when building from a directory copy
(as Mike learned the hard way)

  ----

PS: I used NNTP and http://dir.gmane.org/gmane.comp.version-control.git
to quickly find this old thread (what could we do without NNTP?). Then
I googled for a web archive of this thread and Google could only find
this one: http://git.661346.n2.nabble.com/BUG-in-git-diff-index-tt7652105.html#none
Is there a robots.txt to block indexing on
https://public-inbox.org/git/1459432667.2124.2.camel@dwim.me ?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: BUG in git diff-index Marc Herbert <Marc.Herbert@intel.com> - 2017-09-26 21:50 +0200
  Re: BUG in git diff-index Eric Wong <e@80x24.org> - 2017-09-26 22:20 +0200
  Wrong -dirty suffix set by setlocalversion (was: BUG in git  diff-index) Marc Herbert <Marc.Herbert@intel.com> - 2017-09-27 23:10 +0200

csiph-web