[PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	[PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs
Date	2017-09-26 21:10 +0200
Message-ID	<uu3p0-jm-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

mv88e6xxx_g2_irq_free locks the registers mutex, but not
mv88e6xxx_g1_irq_free, which results in a stack trace from
assert_reg_lock when unloading the mv88e6xxx module. Fix this.

Fixes: 3460a5770ce9 ("net: dsa: mv88e6xxx: Mask g1 interrupts and free interrupt")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index c6678aa9b4ef..e7ff7483d2fb 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3947,7 +3947,9 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev)
 	if (chip->irq > 0) {
 		if (chip->info->g2_irqs > 0)
 			mv88e6xxx_g2_irq_free(chip);
+		mutex_lock(&chip->reg_lock);
 		mv88e6xxx_g1_irq_free(chip);
+		mutex_unlock(&chip->reg_lock);
 	}
 }
 
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-26 21:10 +0200
  Re: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs Florian Fainelli <f.fainelli@gmail.com> - 2017-09-26 21:10 +0200
  RE: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs David Laight <David.Laight@ACULAB.COM> - 2017-09-27 11:10 +0200
    Re: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs Andrew Lunn <andrew@lunn.ch> - 2017-09-27 15:10 +0200
      RE: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs David Laight <David.Laight@ACULAB.COM> - 2017-09-27 18:50 +0200
  Re: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing  IRQs David Miller <davem@davemloft.net> - 2017-09-28 19:30 +0200

csiph-web