Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag

From	"Darrick J. Wong" <darrick.wong@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag
Date	2017-09-26 20:10 +0200
Message-ID	<uu2sX-8cl-53@gated-at.bofh.it> (permalink)
References	<utKPp-4Lc-5@gated-at.bofh.it> <utKPq-4Lc-25@gated-at.bofh.it> <utRHc-10R-17@gated-at.bofh.it> <uu1Gy-7EH-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 26, 2017 at 11:16:38AM -0600, Ross Zwisler wrote:
> On Tue, Sep 26, 2017 at 08:36:50AM +0200, Christoph Hellwig wrote:
> > On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote:
> > > Currently only the blocksize is checked, but we should really be calling
> > > bdev_dax_supported() which also tests to make sure we can get a
> > > struct dax_device and that the dax_direct_access() path is working.
> > > 
> > > This is the same check that we do for the "-o dax" mount option in
> > > xfs_fs_fill_super().
> > > 
> > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > 
> > I think we just want to pick this up ASAP.  And between my vague
> > memoried and that reviewed-by tag it already was part of a different
> > series, wasn't it?
> 
> Yep, the first 2 patches were part of this series:
> 
> https://lkml.org/lkml/2017/9/7/552
> 
> which you reviewed.  I included them in this series because the later patches
> needed to build on them.  It looks like they are now in Darrick's
> xfs-4.14-fixes branch, but haven't yet made it upstream.

I'm pulling that first patch from -fixes because Dave & Christoph
started discussing it again in this new thread after I'd pushed the
patch from September 7th to korg.

The second patch looks fine, it'll stay.

--D

> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/7] xfs: validate bdev support for DAX inode flag Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-09-26 01:20 +0200
  Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag Christoph Hellwig <hch@lst.de> - 2017-09-26 08:40 +0200
    Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag Ross Zwisler <ross.zwisler@linux.intel.com> - 2017-09-26 19:20 +0200
      Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-09-26 20:10 +0200

csiph-web