Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1740080

Re: [PATCH v4 2/2] staging: ion: create one device entry per heap

From Laura Abbott <labbott@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 2/2] staging: ion: create one device entry per heap
Date 2017-09-26 20:10 +0200
Message-ID <uu2sW-8cl-35@gated-at.bofh.it> (permalink)
References <utWQx-4Cp-7@gated-at.bofh.it> <utWQx-4Cp-5@gated-at.bofh.it> <uu0Ku-732-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 09/26/2017 09:17 AM, Mark Brown wrote:
> On Tue, Sep 26, 2017 at 02:07:05PM +0200, Benjamin Gaignard wrote:
> 
>> version 4:
>> - add a configuration flag to switch between legacy Ion misc device
>>    and one device per heap version.
> 
> Should this be a switch or should it just be enabling and disabling the
> legacy device with the per heap ones always availalbe?  I can't see that
> the new devices would do any harm or have trouble interacting with the
> per heap ones.  Being able to have both enabled would make things easier
> for userspaces that are moving to the device per heap interface.
> 

Agreed. We should be enabling the new interface unconditionally. The
old /dev/ion interface should coexist to allow for backwards
compatibility but keep it under a Kconfig to allow it to be turned off
for security or other reasons.

Thanks,
Laura

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v4 2/2] staging: ion: create one device entry per heap Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-09-26 14:10 +0200
  Re: [PATCH v4 2/2] staging: ion: create one device entry per heap Mark Brown <broonie@kernel.org> - 2017-09-26 18:20 +0200
    Re: [PATCH v4 2/2] staging: ion: create one device entry per heap Laura Abbott <labbott@redhat.com> - 2017-09-26 20:10 +0200

csiph-web