Re: [PATCH net] net: dsa: mv88e6xxx: lock mutex when freeing IRQs

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net: dsa: mv88e6xxx: lock mutex when freeing IRQs
Date	2017-09-26 20:10 +0200
Message-ID	<uu2sW-8cl-23@gated-at.bofh.it> (permalink)
References	<uu2jh-7SW-17@gated-at.bofh.it> <uu2sW-8cl-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> In general, i tried to keep the mutex out of the interrupt code.  That
> is not totally possible, the IRQ thread handler needs it. But
> otherwise, the IRQ code assumes it is called with the mutex taken.
>
> So i think it is better to hold the mutex in mv88e6xxx_remove() when
> calling mv88e6xxx_g1_irq_free().

I'd prefer that too. Respinning, thanks!


    Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net: dsa: mv88e6xxx: lock mutex when freeing IRQs Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-26 20:00 +0200
  Re: [PATCH net] net: dsa: mv88e6xxx: lock mutex when freeing IRQs Andrew Lunn <andrew@lunn.ch> - 2017-09-26 20:10 +0200
    Re: [PATCH net] net: dsa: mv88e6xxx: lock mutex when freeing IRQs Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-26 20:10 +0200

csiph-web