Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740074

Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

Show all headers | View raw

Hello Vinod! Thanks for review!

> 26 сент. 2017 г., в 20:37, Vinod Koul <vinod.koul@intel.com> написал(а):
> 
> Tested-by please...

In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC defined to 1
and with some trace code included. Is it OK if I provide second patch I used for testing
with trace showing how change work?

> one more wrapper why, we dont have any logic here!
The idea was to keep rest of driver code intact. Ok, I’ll send v2 with no wrappers.

> right justifed please


Some functions has two tabs on second line, some has alignment to beginning of
argument declaration. How correct?

1) or like this (two tabs)
static int add_desc(struct list_head *pool, spinlock_t *lock,
                gfp_t flg, int count)

2) Like this:
static int add_desc(struct list_head *pool, spinlock_t *lock,
		               gfp_t flg, int count)

Regards,
Alexander.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail Vinod Koul <vinod.koul@intel.com> - 2017-09-26 19:40 +0200
  Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail Alexander Kochetkov <al.kochet@gmail.com> - 2017-09-26 20:10 +0200
    Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail Vinod Koul <vinod.koul@intel.com> - 2017-09-28 09:50 +0200

csiph-web