Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740092
| From | Robin Murphy <robin.murphy@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU |
| Date | 2017-09-26 20:20 +0200 |
| Message-ID | <uu2CB-8fI-1@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <utGC7-1Kz-35@gated-at.bofh.it> <utP2G-7zs-13@gated-at.bofh.it> <utX9T-4JB-19@gated-at.bofh.it> <utZ22-5UA-7@gated-at.bofh.it> <uu1Qd-7HQ-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 26/09/17 15:34, Raj, Ashok wrote:
> On Tue, Sep 26, 2017 at 03:22:47PM +0100, Robin Murphy wrote:
>> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
>> index 6784a05dd6b2..d7f7def81613 100644
>> --- a/drivers/iommu/intel-iommu.c
>> +++ b/drivers/iommu/intel-iommu.c
>> @@ -2254,10 +2254,12 @@ static int __domain_mapping(struct dmar_domain *domain, unsigned long iov_pfn,
>> uint64_t tmp;
>>
>> if (!sg_res) {
>> + size_t off = sg->offset & ~PAGE_MASK;
>
> Should this be VTD_PAGE_MASK?
PAGE_MASK (and the corresponding pteval arithmetic) was intentional
here; given the way aligned_nrpages() works, the IOVA space allocated in
intel_map_sg() (and thus iov_pfn) is already rounded to full MM pages,
and it seemed like the original intent was to map the whole lot - this
change is just to make that happen correctly.
Whether it's actually reasonable to decouple the IOMMU and CPU page
sizes entirely (as we do in dma-iommu, for example), and not do the
MM-page-alignment thing at all, is another matter that I'm happy to
leave in your hands :)
Robin.
>> +
>> sg_res = aligned_nrpages(sg->offset, sg->length);
>> - sg->dma_address = ((dma_addr_t)iov_pfn << VTD_PAGE_SHIFT) + sg->offset;
>> + sg->dma_address = ((dma_addr_t)iov_pfn << VTD_PAGE_SHIFT) + off;
>> sg->dma_length = sg->length;
>> - pteval = page_to_phys(sg_page(sg)) | prot;
>> + pteval = (page_to_phys(sg_page(sg)) + sg->offset - off) | prot;
>
> Something seems wrong here.. sg->offset can be > VTD_PAGE_SIZE, think
> we should add sg->offset and then find the pteval?
>
> attached below another cut at fixing the same problem.. if there is something
> obvious i missed, let me know.
>
> again.. untested :-)
>
> Cheers,
> Ashok
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-16 08:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Herbert Xu <herbert@gondor.apana.org.au> - 2017-09-20 10:10 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Robin Murphy <robin.murphy@arm.com> - 2017-09-20 12:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-20 13:30 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-25 19:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU "Raj, Ashok" <ashok.raj@intel.com> - 2017-09-25 20:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-25 20:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-26 05:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-26 14:30 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Robin Murphy <robin.murphy@arm.com> - 2017-09-26 16:30 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Dan Williams <dan.j.williams@intel.com> - 2017-09-26 18:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-27 18:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Dan Williams <dan.j.williams@intel.com> - 2017-09-27 19:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Christoph Hellwig <hch@infradead.org> - 2017-10-01 11:00 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU "Raj, Ashok" <ashok.raj@intel.com> - 2017-09-27 19:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-27 23:30 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU "Raj, Ashok" <ashok.raj@intel.com> - 2017-09-28 00:10 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-28 00:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-28 07:10 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Herbert Xu <herbert@gondor.apana.org.au> - 2017-09-28 12:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-28 15:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU "Raj, Ashok" <ashok.raj@intel.com> - 2017-09-28 18:10 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-29 07:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-27 19:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU "Raj, Ashok" <ashok.raj@intel.com> - 2017-09-26 19:30 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-26 23:00 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU "Raj, Ashok" <ashok.raj@intel.com> - 2017-09-26 19:30 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Robin Murphy <robin.murphy@arm.com> - 2017-09-26 20:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-26 19:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Dan Williams <dan.j.williams@intel.com> - 2017-09-25 21:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-25 22:10 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Dan Williams <dan.j.williams@intel.com> - 2017-09-25 22:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU "Raj, Ashok" <ashok.raj@intel.com> - 2017-09-25 23:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-26 01:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-26 15:10 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-20 13:40 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU David Woodhouse <dwmw2@infradead.org> - 2017-09-25 20:50 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Casey Leedom <leedom@chelsio.com> - 2017-09-25 22:20 +0200
Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU Harsh Jain <Harsh@chelsio.com> - 2017-09-26 13:20 +0200
csiph-web