Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.

From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.
Date	2017-09-25 08:20 +0200
Message-ID	<utuUi-2ui-15@gated-at.bofh.it> (permalink)
References	<utaLU-6tN-11@gated-at.bofh.it> <utaLU-6tN-19@gated-at.bofh.it> <utnJ8-659-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

	On Mon, 2017-09-25 at 00:37 +0200, Rafael J. Wysocki wrote:
> On Sun, Sep 24, 2017 at 10:35 AM, Tomas Winkler <tomas.winkler@intel.com> wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> > 
> > This patch fixes a regression caused by the new changes
> > in the run wake handlers, pci_dev_run_wake() return true
> > when wake is possible from the software perspective
> > not whether it is actually enabled.
> 
> This isn't exactly accurate, because "run wake" used to mean "wakeup
> signals can be generated for this device in the working state of the
> system", so it could not be enabled or disabled before too.  It's just
> that the function returns "true" for (at least) some devices for which
> it used to return "false" (arguably incorrectly).
> 
> Other than that I agree with the patch.

Thanks for the correction, I will respin the patch with your
explanation.

Thanks
Tomas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[char-misc 0/2] mei updates for 4.14-rc2 Tomas Winkler <tomas.winkler@intel.com> - 2017-09-24 10:50 +0200
  [char-misc 1/2] mei: always use domain runtime pm callbacks. Tomas Winkler <tomas.winkler@intel.com> - 2017-09-24 10:50 +0200
    Re: [char-misc 1/2] mei: always use domain runtime pm callbacks. "Rafael J. Wysocki" <rafael@kernel.org> - 2017-09-25 00:40 +0200
      Re: [char-misc 1/2] mei: always use domain runtime pm callbacks. "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-09-25 08:20 +0200

csiph-web