Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738702

[PATCH review for 4.9 14/50] f2fs: do SSR for data when there is enough free space

Path csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Newsgroups linux.kernel
Subject [PATCH review for 4.9 14/50] f2fs: do SSR for data when there is enough free space
Date Mon, 25 Sep 2017 03:40:03 +0200
Message-ID <utqxl-7O2-43@gated-at.bofh.it> (permalink)
References <utqdY-7Fr-3@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506302041; x=1537838041; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uXGD5Rdkrf8pwAwPm25t2SDjfmqY5+8kl7bxULiWJIg=; b=T8jMULnnV3k43nP5FMvmZD+1eIDc2IebnlTs1oxCY3NOAY0zpp2nUS3m 4iFg0xx+SeHCxikMMrj4bAYRrX3ET+BLN862og7gCTVnukqvReTHetqji 2D/ySxXTakx177tmojZ0nVXbal6nIknY/vFMUyX5nw/508l+Xc89FI+Va U=;
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301970; x=1537837970; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uXGD5Rdkrf8pwAwPm25t2SDjfmqY5+8kl7bxULiWJIg=; b=RSWkChMirqXJ2/ME+sATS8JXBPvxNpWDHUkJeZ9GSg2ejJIr4INSkJI3 HhG1d/9ohV0+P33M3p7kBKLNBgYT59qsJCS5My9OaLsw/qry7DOVTcK2j fG++QCe43Xah83/3913/Vft5M4F1pmJGBR46EEPN9BHbIChmeGYkP4j7Y 8=;
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301969; x=1537837969; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uXGD5Rdkrf8pwAwPm25t2SDjfmqY5+8kl7bxULiWJIg=; b=vIPBoclpRwi8YlvCSiw3WyL21VJOdya01bWA6Kx4sxd2OZzFVosBFSUY +lp+hbVikJQZMMv2a/JaetuffFLAHFwdxlS9BP0eBs5fSuO00SnrYbqMi KTyqZDTx855Zl6Iun/vLzBoh/VRwA7ZP2T/iP9+Thtubib+CZI3FBBnEm 4=;
X-Host viking.odc.vzwcorp.com
Thread-Topic [PATCH review for 4.9 14/50] f2fs: do SSR for data when there is enough free space
Thread-Index AQHTNZtk1+wtjWY96EWr/pAVJO4CHw==
Accept-Language en-US
Content-Language en-US
X-Ms-Exchange-Messagesentrepresentingtype 1
X-Ms-Exchange-Transport-Fromentityheader Hosted
X-Originating-IP [10.144.60.250]
Content-Type text/plain; charset="iso-8859-1"
Content-Transfer-Encoding quoted-printable
MIME-Version 1.0
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 32
Organization linux.* mail to news gateway
X-Original-Cc Yunlong Song <yunlong.song@huawei.com>, Jaegeuk Kim <jaegeuk@kernel.org>, "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
X-Original-Date Mon, 25 Sep 2017 01:12:44 +0000
X-Original-Message-ID <20170925011225.10029-14-alexander.levin@verizon.com>
X-Original-References <20170925011225.10029-1-alexander.levin@verizon.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1738702

Show key headers only | View raw


From: Yunlong Song <yunlong.song@huawei.com>

[ Upstream commit 035e97adab26c1121cedaeb9bd04cf48a8e8cf51 ]

In allocate_segment_by_default(), need_SSR() already detected it's time to do
SSR. So, let's try to find victims for data segments more aggressively in time.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 fs/f2fs/segment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 74a2b444406d..e10f61684ea4 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1263,7 +1263,7 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
 	struct curseg_info *curseg = CURSEG_I(sbi, type);
 	const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops;
 
-	if (IS_NODESEG(type) || !has_not_enough_free_secs(sbi, 0, 0))
+	if (IS_NODESEG(type))
 		return v_ops->get_victim(sbi,
 				&(curseg)->next_segno, BG_GC, type, SSR);
 
-- 
2.11.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH review for 4.9 01/50] xen-netback: Use GFP_ATOMIC to allocate  hash "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 17/50] f2fs: do not wait for writeback in  write_begin "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 15/50] sched/fair: Update rq clock before  changing a task's CPU affinity "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 26/50] ASoC: mediatek: add I2C dependency for  CS42XX8 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 42/50] hrtimer: Catch invalid clockids again "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 06/50] mac80211_hwsim: check  HWSIM_ATTR_RADIO_NAME length "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 07/50] ALSA: hda: Add Geminilake HDMI codec ID "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 05/50] initramfs: finish fput() before  accessing any binary from initramfs "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 14/50] f2fs: do SSR for data when there is  enough free space "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 02/50] locking/lockdep: Add nest_lock integrity  test "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 18/50] md/linear: shutup lockdep warnning "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 12/50] netfilter: nf_ct_expect: Change  __nf_ct_expect_check() return value. "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 24/50] slub: do not merge cache if slub_debug  contains a never-merge flag "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200

csiph-web