Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738691

[PATCH review for 4.9 21/50] crypto: xts - Add ECB dependency

Path csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Newsgroups linux.kernel
Subject [PATCH review for 4.9 21/50] crypto: xts - Add ECB dependency
Date Mon, 25 Sep 2017 03:40:02 +0200
Message-ID <utqxk-7O2-19@gated-at.bofh.it> (permalink)
References <utqdY-7Fr-3@gated-at.bofh.it>
X-Original-To "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506302057; x=1537838057; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qUkfbbv7CmyOdVh0b7v0BXgQjpoVz2TZ445oqNeG9S8=; b=Ea/w8BWGsDRCVIRsv6t8c7jnaEj0TI2HaisT+EiPuomTAqYMl6rJhF12 tWpNRac9m51NisgUE2aqFulrucFqzIgmw48XDTmJ6cTRrafFQVQZN+P7O mSlw75QezLQbD709dalV0SAf95iy7wZqG7EcWHWKWpsKQhuI/Zs4jXMDl 0=;
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301974; x=1537837974; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qUkfbbv7CmyOdVh0b7v0BXgQjpoVz2TZ445oqNeG9S8=; b=dRgqX67/daT1UGknLL/cRy+ZE+JdfmQp0ASrUhypjFSbJuc6ez1RbaIU RAsYSyMVYf3SWiC6yzgbZ/mCsritDQymI1dZWKvyZET9gqVcj1UBsLU3s ysJeQ1/5mBA0JHf5K4PKBym+JzrChtBueshpouvv7udV/+xsEYFHGbnhr 8=;
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301975; x=1537837975; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qUkfbbv7CmyOdVh0b7v0BXgQjpoVz2TZ445oqNeG9S8=; b=u12/IRnaxKNkxs7sOyvTkIumjx7P6rFEy9FxNGAAkj4e4s7riwa6ZCBP 3wak7tPI1JhdFyxqeOjVrJ9ICmZwUupM/bbO8ajXoJG33u+kF7zacQYJo Sp0ci0OtxLZ0i/rrVU3oRPxo1Cg6kdZDicLU/RrY4WmgbJ8e5s1GlNbgV g=;
X-Host discovery.odc.vzwcorp.com
Thread-Topic [PATCH review for 4.9 21/50] crypto: xts - Add ECB dependency
Thread-Index AQHTNZtm/9UM6nVOkkCniB5A0nWb2g==
Accept-Language en-US
Content-Language en-US
X-Ms-Exchange-Messagesentrepresentingtype 1
X-Ms-Exchange-Transport-Fromentityheader Hosted
X-Originating-IP [10.144.60.250]
Content-Type text/plain; charset="iso-8859-1"
Content-Transfer-Encoding quoted-printable
MIME-Version 1.0
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 31
Organization linux.* mail to news gateway
X-Original-Cc Milan Broz <gmazyland@gmail.com>, Herbert Xu <herbert@gondor.apana.org.au>, "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
X-Original-Date Mon, 25 Sep 2017 01:12:48 +0000
X-Original-Message-ID <20170925011225.10029-21-alexander.levin@verizon.com>
X-Original-References <20170925011225.10029-1-alexander.levin@verizon.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1738691

Show key headers only | View raw


From: Milan Broz <gmazyland@gmail.com>

[ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ]

Since the
   commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40
   crypto: xts - Convert to skcipher
the XTS mode is based on ECB, so the mode must select
ECB otherwise it can fail to initialize.

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 84d71482bf08..fa98ad7edb60 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -360,6 +360,7 @@ config CRYPTO_XTS
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_MANAGER
 	select CRYPTO_GF128MUL
+	select CRYPTO_ECB
 	help
 	  XTS: IEEE1619/D16 narrow block cipher use with aes-xts-plain,
 	  key size 256, 384 or 512 bits. This implementation currently
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH review for 4.9 21/50] crypto: xts - Add ECB dependency "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200

csiph-web