Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738694

[PATCH review for 4.9 01/50] xen-netback: Use GFP_ATOMIC to allocate hash

Path csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Newsgroups linux.kernel
Subject [PATCH review for 4.9 01/50] xen-netback: Use GFP_ATOMIC to allocate hash
Date Mon, 25 Sep 2017 03:40:02 +0200
Message-ID <utqdY-7Fr-3@gated-at.bofh.it> (permalink)
X-Original-To "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506302052; x=1537838052; h=from:cc:to:subject:date:message-id: content-transfer-encoding:mime-version; bh=KO0wzTMhyqCtFr/Hbn1ALBhpZf4hwqBs+UFuc9lI+ao=; b=jftLIgrQlvLHIYuHiCPhSONjCNqIa6TUf7kL9XEpzQS7waOku1Xj3l5W euwR9f1OQxTXbU1/yYIarGnxoNs7pgHOfyq34/bhLIxAOGpIt8O79mO7G 6X5ui+9Dt08eFQdT5kAOS5613PTNNXF3wnUYsrsCnCUIkQmPueeMHPBwv c=;
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301966; x=1537837966; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=KO0wzTMhyqCtFr/Hbn1ALBhpZf4hwqBs+UFuc9lI+ao=; b=ngTtjrRfeOGch6InCvoOPyzS+8JC9yPVTCnHWiJEbPBfm3SnQaXB9+cm s55/hsmBHJk0nFimHMJEW0+DBX9T6y/aVpRTqd5rau5GT6JGNLyM8Q6k2 L4APBs1bodD1fJryW+JTceezJZqEqcIgOtlLo7et/jeEmmLByGV/opHw7 s=;
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506301966; x=1537837966; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=KO0wzTMhyqCtFr/Hbn1ALBhpZf4hwqBs+UFuc9lI+ao=; b=ngTtjrRfeOGch6InCvoOPyzS+8JC9yPVTCnHWiJEbPBfm3SnQaXB9+cm s55/hsmBHJk0nFimHMJEW0+DBX9T6y/aVpRTqd5rau5GT6JGNLyM8Q6k2 L4APBs1bodD1fJryW+JTceezJZqEqcIgOtlLo7et/jeEmmLByGV/opHw7 s=;
X-Host discovery.odc.vzwcorp.com
Thread-Topic [PATCH review for 4.9 01/50] xen-netback: Use GFP_ATOMIC to allocate hash
Thread-Index AQHTNZthZf63dI8gBk6fquJPZ2cxOA==
Accept-Language en-US
Content-Language en-US
X-Ms-Exchange-Messagesentrepresentingtype 1
X-Ms-Exchange-Transport-Fromentityheader Hosted
X-Originating-IP [10.144.60.250]
Content-Type text/plain; charset="iso-8859-1"
Content-Transfer-Encoding quoted-printable
MIME-Version 1.0
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 32
Organization linux.* mail to news gateway
X-Original-Cc Anoob Soman <anoob.soman@citrix.com>, "David S . Miller" <davem@davemloft.net>, "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
X-Original-Date Mon, 25 Sep 2017 01:12:39 +0000
X-Original-Message-ID <20170925011225.10029-1-alexander.levin@verizon.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1738694

Show key headers only | View raw


From: Anoob Soman <anoob.soman@citrix.com>

[ Upstream commit 9f674e48c13dcbc31ac903433727837795b81efe ]

Allocation of new_hash, inside xenvif_new_hash(), always happen
in softirq context, so use GFP_ATOMIC instead of GFP_KERNEL for new
hash allocation.

Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 drivers/net/xen-netback/hash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-netback/hash.c
index e8c5dddc54ba..3c4c58b9fe76 100644
--- a/drivers/net/xen-netback/hash.c
+++ b/drivers/net/xen-netback/hash.c
@@ -39,7 +39,7 @@ static void xenvif_add_hash(struct xenvif *vif, const u8 *tag,
 	unsigned long flags;
 	bool found;
 
-	new = kmalloc(sizeof(*entry), GFP_KERNEL);
+	new = kmalloc(sizeof(*entry), GFP_ATOMIC);
 	if (!new)
 		return;
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH review for 4.9 01/50] xen-netback: Use GFP_ATOMIC to allocate  hash "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 17/50] f2fs: do not wait for writeback in  write_begin "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 15/50] sched/fair: Update rq clock before  changing a task's CPU affinity "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 26/50] ASoC: mediatek: add I2C dependency for  CS42XX8 "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 42/50] hrtimer: Catch invalid clockids again "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 06/50] mac80211_hwsim: check  HWSIM_ATTR_RADIO_NAME length "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 07/50] ALSA: hda: Add Geminilake HDMI codec ID "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 05/50] initramfs: finish fput() before  accessing any binary from initramfs "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 14/50] f2fs: do SSR for data when there is  enough free space "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 02/50] locking/lockdep: Add nest_lock integrity  test "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 18/50] md/linear: shutup lockdep warnning "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 12/50] netfilter: nf_ct_expect: Change  __nf_ct_expect_check() return value. "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200
  [PATCH review for 4.9 24/50] slub: do not merge cache if slub_debug  contains a never-merge flag "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-09-25 03:40 +0200

csiph-web