[PATCH v4 01/10] clk: fix incorrect usage of ENOSYS

From	Jerome Brunet <jbrunet@baylibre.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 01/10] clk: fix incorrect usage of ENOSYS
Date	2017-09-24 22:10 +0200
Message-ID	<utlnX-4Gy-1@gated-at.bofh.it> (permalink)
References	<utlnX-4Gy-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

ENOSYS is special and should only be used for incorrect syscall number.
It does not seem to be the case here.

Reported by checkpatch.pl while working on clock protection.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Quentin Schulz <quentin.schulz@free-electrons.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/clk/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index c8d83acda006..b31e56b09e25 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1804,7 +1804,7 @@ static int clk_core_set_parent(struct clk_core *core, struct clk_core *parent)
 
 	/* verify ops for for multi-parent clks */
 	if ((core->num_parents > 1) && (!core->ops->set_parent)) {
-		ret = -ENOSYS;
+		ret = -EPERM;
 		goto out;
 	}
 
-- 
2.13.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v4 01/10] clk: fix incorrect usage of ENOSYS Jerome Brunet <jbrunet@baylibre.com> - 2017-09-24 22:10 +0200

csiph-web