Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1738236

[PATCH RESEND] ncpfs: ioctl: Delete unnecessary len variables

Show all headers | View raw

Variables oldnamelen, oldprivatelen and oldlen are set but are never
used, thus they need to be cleaned up.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 fs/ncpfs/ioctl.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/fs/ncpfs/ioctl.c b/fs/ncpfs/ioctl.c
index 12550c2..85c6c60 100644
--- a/fs/ncpfs/ioctl.c
+++ b/fs/ncpfs/ioctl.c
@@ -642,9 +642,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			struct ncp_objectname_ioctl user;
 			void* newname;
 			void* oldname;
-			size_t oldnamelen;
 			void* oldprivate;
-			size_t oldprivatelen;
 
 #ifdef CONFIG_COMPAT
 			if (cmd == NCP_IOC_SETOBJECTNAME_32) {
@@ -671,9 +669,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			}
 			down_write(&server->auth_rwsem);
 			oldname = server->auth.object_name;
-			oldnamelen = server->auth.object_name_len;
 			oldprivate = server->priv.data;
-			oldprivatelen = server->priv.len;
 			server->auth.auth_type = user.auth_type;
 			server->auth.object_name_len = user.object_name_len;
 			server->auth.object_name = newname;
@@ -742,7 +738,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			struct ncp_privatedata_ioctl user;
 			void* new;
 			void* old;
-			size_t oldlen;
 
 #ifdef CONFIG_COMPAT
 			if (cmd == NCP_IOC_SETPRIVATEDATA_32) {
@@ -767,7 +762,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
 			}
 			down_write(&server->auth_rwsem);
 			old = server->priv.data;
-			oldlen = server->priv.len;
 			server->priv.len = user.len;
 			server->priv.data = new;
 			up_write(&server->auth_rwsem);
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH RESEND] ncpfs: ioctl: Delete unnecessary len variables Christos Gkekas <chris.gekas@gmail.com> - 2017-09-24 19:50 +0200

csiph-web