Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738225
| From | Stefan Wahren <stefan.wahren@i2se.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 resend] staging: bcm2835-audio: Fix memory corruption |
| Date | 2017-09-24 18:30 +0200 |
| Message-ID | <uthX3-2wB-3@gated-at.bofh.it> (permalink) |
| References | <utgoh-1tS-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> Phil Elwell <phil@raspberrypi.org> hat am 24. September 2017 um 16:20 geschrieben:
>
>
> The previous commit (0adbfd46) fixed a memory leak but also freed a
> block in the success case, causing a stale pointer to be used with
> potentially fatal results. Only free the vchi_instance block in the
> case that vchi_connect fails; once connected, the instance is
> retained for subsequent connections.
>
> Simplifying the code by removing a bunch of gotos and returning errors
> directly.
>
> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
> Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in bcm2835_audio_open_connection()")
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 resend] staging: bcm2835-audio: Fix memory corruption Phil Elwell <phil@raspberrypi.org> - 2017-09-24 16:50 +0200 Re: [PATCH v2 resend] staging: bcm2835-audio: Fix memory corruption Stefan Wahren <stefan.wahren@i2se.com> - 2017-09-24 18:30 +0200
csiph-web