Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739947

Re: [PATCHv2] percpu: make this_cpu_generic_read() atomic w.r.t. interrupts

Show all headers | View raw

On Tue, Sep 26, 2017 at 12:41:52PM +0100, Mark Rutland wrote:
> As raw_cpu_generic_read() is a plain read from a raw_cpu_ptr() address,
> it's possible (albeit unlikely) that the compiler will split the access
> across multiple instructions.
> 
> In this_cpu_generic_read() we disable preemption but not interrupts
> before calling raw_cpu_generic_read(). Thus, an interrupt could be taken
> in the middle of the split load instructions. If a this_cpu_write() or
> RMW this_cpu_*() op is made to the same variable in the interrupt
> handling path, this_cpu_read() will return a torn value.
> 
> For native word types, we can avoid tearing using READ_ONCE(), but this
> won't work in all cases (e.g. 64-bit types on most 32-bit platforms).
> This patch reworks this_cpu_generic_read() to use READ_ONCE() where
> possible, otherwise falling back to disabling interrupts.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Christoph Lameter <cl@linux.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Pranith Kumar <bobby.prani@gmail.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-arch@vger.kernel.org

Applied to percpu/for-4.14-fixes.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2] percpu: make this_cpu_generic_read() atomic w.r.t. interrupts Mark Rutland <mark.rutland@arm.com> - 2017-09-26 13:50 +0200
  Re: [PATCHv2] percpu: make this_cpu_generic_read() atomic w.r.t.  interrupts Tejun Heo <tj@kernel.org> - 2017-09-26 16:50 +0200

csiph-web