Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813
Date	2017-09-26 15:20 +0200
Message-ID	<utXWi-5gz-21@gated-at.bofh.it> (permalink)
References	<utX0e-4FS-7@gated-at.bofh.it> <utX0e-4FS-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote:
> As pinctrl and GPIO driver now supports AXP813, add a cell for it.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> ---
>  drivers/mfd/axp20x.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 336de66..a457528 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = {
>  		.name			= "axp221-pek",
>  		.num_resources		= ARRAY_SIZE(axp803_pek_resources),
>  		.resources		= axp803_pek_resources,
> +	}, {
> +		.name			= "axp20x-gpio",
> +		.of_compatible		= "x-powers,axp813-pctl",

This was probably introduced in the previous driver, but why are you
using the pctl suffix? Can't we just use the GPIO one to remain
consistent with the previous users and the datasheet?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-26 14:20 +0200
  Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-26 15:20 +0200
    Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813 Lee Jones <lee.jones@linaro.org> - 2017-09-28 21:10 +0200

csiph-web