Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

From	Mark yao <mark.yao@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"
Date	2017-09-26 11:10 +0200
Message-ID	<utU2n-2KN-33@gated-at.bofh.it> (permalink)
References	(1 earlier) <urVOW-J7-11@gated-at.bofh.it> <urYa6-2kx-13@gated-at.bofh.it> <utQrL-gt-1@gated-at.bofh.it> <utRHc-10R-21@gated-at.bofh.it> <utT6h-26b-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017年09月26日 16:08, Daniel Vetter wrote:
> On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote:
>> On 2017年09月26日 13:12, Daniel Vetter wrote:
>>> On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote:
>>>> On 2017年09月21日 06:29, Thomas Meyer wrote:
>>>>> Use vma_pages function on vma object instead of explicit computation.
>>>>> Found by coccinelle spatch "api/vma_pages.cocci"
>>>>>
>>>>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>>>>> ---
>>>> Looks good for me:
>>>> Acked-by: Mark Yao <mark.yao@rock-chips.com>
>>> Once more a maintainer who acks a patch and doesn't push it. This is
>>> really confusing, who exactly do you expect to handle this patch for you?
>>>
>>> Please push to drm-misc-next (also for future patches), thanks.
>>> -Daniel
>> Hi Daniel
>> I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series.
>>
>> Ok, Pushed it to drm-misc-next.
> Hm right, but I only see 7/7 here. Either way, except when the author asks
> for a preferred tree it's best if you just pick things up right away. And
> if you're unsure, just ask instead of risking that a patch drops through
> the cracks.
> -Daniel

Okay, I'll keep it in mind next time.

Thanks
Mark

>
>>>>> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>>>> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
>>>>>     {
>>>>>     	struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
>>>>>     	unsigned int i, count = obj->size >> PAGE_SHIFT;
>>>>> -	unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
>>>>> +	unsigned long user_count = vma_pages(vma);
>>>>>     	unsigned long uaddr = vma->vm_start;
>>>>>     	unsigned long offset = vma->vm_pgoff;
>>>>>     	unsigned long end = user_count + offset;
>>>>>
>>>>> _______________________________________________
>>>>> Linux-rockchip mailing list
>>>>> Linux-rockchip@lists.infradead.org
>>>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>>>>>
>>>>>
>>>>>
>>>> -- 
>>>> Ｍark Yao
>>>>
>>>>
>>>> _______________________________________________
>>>> dri-devel mailing list
>>>> dri-devel@lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
>> -- 
>> Ｍark Ya
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" Thomas Meyer <thomas@m3y3r.de> - 2017-09-21 00:40 +0200
  Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" Mark yao <mark.yao@rock-chips.com> - 2017-09-21 03:10 +0200
    Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" Daniel Vetter <daniel@ffwll.ch> - 2017-09-26 07:20 +0200
      Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" Mark yao <mark.yao@rock-chips.com> - 2017-09-26 08:40 +0200
        Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" Daniel Vetter <daniel@ffwll.ch> - 2017-09-26 10:10 +0200
          Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" Mark yao <mark.yao@rock-chips.com> - 2017-09-26 11:10 +0200

csiph-web