Re: [PATCH] hv_netvsc: make const array ver_list static, reduces object code size

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hv_netvsc: make const array ver_list static, reduces object code size
Date	2017-09-26 01:30 +0200
Message-ID	<utKZ4-4P8-23@gated-at.bofh.it> (permalink)
References	<usywW-7Vf-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Fri, 22 Sep 2017 16:50:23 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate const array ver_list on the stack, instead make it
> static. Makes the object code smaller by over 400 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   18444	   3168	    320	  21932	   55ac	drivers/net/hyperv/netvsc.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   17950	   3224	    320	  21494	   53f6	drivers/net/hyperv/netvsc.o
> 
> (gcc 6.3.0, x86-64)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] hv_netvsc:  make const array ver_list static, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-22 18:00 +0200
  RE: [PATCH] hv_netvsc:  make const array ver_list static, reduces  object code size Haiyang Zhang <haiyangz@microsoft.com> - 2017-09-22 18:10 +0200
  Re: [PATCH] hv_netvsc: make const array ver_list static, reduces  object code size David Miller <davem@davemloft.net> - 2017-09-26 01:30 +0200

csiph-web