Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739234

Re: [patch v2] mremap.2: Add description of old_size == 0 functionality

Show key headers only | View raw

Hi Mike,

On 25 September 2017 at 18:33, Mike Kravetz <mike.kravetz@oracle.com> wrote:
> On 09/20/2017 12:25 AM, Michael Kerrisk (man-pages) wrote:

[...]

>> I've applied this, and added Reviewed-by tags for Florian and Jann.
>> But, I think it's also worth noting the older, now disallowed, behavior,
>> and why the behavior was changed. So I added a note in BUGS:
>>
>>     BUGS
>>        Before Linux 4.14, if old_size was zero and the  mapping  referred
>>        to  by  old_address  was  a private mapping (mmap(2) MAP_PRIVATE),
>>        mremap() created a new private mapping unrelated to  the  original
>>        mapping.   This behavior was unintended and probably unexpected in
>>        user-space applications (since the intention  of  mremap()  is  to
>>        create  a new mapping based on the original mapping).  Since Linux
>>        4.14, mremap() fails with the error EINVAL in this scenario.
>>
>> Does that seem okay?
>
> Sorry for the late reply Michael,  I've been away for a few days.
>
> Yes, the above seems okay.  Thanks for your help with this.

You're welcome. Thanks for checking it over!

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] mremap.2: Add description of old_size == 0 functionality Mike Kravetz <mike.kravetz@oracle.com> - 2017-09-15 23:40 +0200
  Re: [patch] mremap.2: Add description of old_size == 0 functionality Mike Kravetz <mike.kravetz@oracle.com> - 2017-09-16 00:00 +0200
    Re: [patch] mremap.2: Add description of old_size == 0 functionality Florian Weimer <fweimer@redhat.com> - 2017-09-18 15:50 +0200
      Re: [patch] mremap.2: Add description of old_size == 0 functionality Mike Kravetz <mike.kravetz@oracle.com> - 2017-09-18 19:20 +0200
        Re: [patch] mremap.2: Add description of old_size == 0 functionality Florian Weimer <fweimer@redhat.com> - 2017-09-19 14:20 +0200
          [patch v2] mremap.2: Add description of old_size == 0 functionality Mike Kravetz <mike.kravetz@oracle.com> - 2017-09-19 23:50 +0200
            Re: [patch v2] mremap.2: Add description of old_size == 0  functionality "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-09-20 09:30 +0200
              Re: [patch v2] mremap.2: Add description of old_size == 0  functionality Michal Hocko <mhocko@kernel.org> - 2017-09-25 14:40 +0200
                Re: [patch v2] mremap.2: Add description of old_size == 0 functionality "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-09-25 14:50 +0200
              Re: [patch v2] mremap.2: Add description of old_size == 0  functionality Mike Kravetz <mike.kravetz@oracle.com> - 2017-09-25 18:40 +0200
                Re: [patch v2] mremap.2: Add description of old_size == 0 functionality "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2017-09-25 21:30 +0200
          Re: [patch] mremap.2: Add description of old_size == 0 functionality Michal Hocko <mhocko@kernel.org> - 2017-09-25 14:40 +0200
            Re: [patch] mremap.2: Add description of old_size == 0 functionality Florian Weimer <fweimer@redhat.com> - 2017-09-25 14:50 +0200
              Re: [patch] mremap.2: Add description of old_size == 0 functionality Michal Hocko <mhocko@kernel.org> - 2017-09-25 15:00 +0200
                Re: [patch] mremap.2: Add description of old_size == 0 functionality Florian Weimer <fweimer@redhat.com> - 2017-09-25 15:20 +0200
                Re: [patch] mremap.2: Add description of old_size == 0 functionality Michal Hocko <mhocko@kernel.org> - 2017-09-25 17:00 +0200
                Re: [patch] mremap.2: Add description of old_size == 0 functionality Florian Weimer <fweimer@redhat.com> - 2017-09-25 17:00 +0200
  Re: [patch] mremap.2: Add description of old_size == 0 functionality Jann Horn <jannh@google.com> - 2017-09-18 04:00 +0200
    Re: [patch] mremap.2: Add description of old_size == 0 functionality Mike Kravetz <mike.kravetz@oracle.com> - 2017-09-18 19:30 +0200

csiph-web