Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739160

Re: [PATCH v7 2/2] security/keys: rewrite all of big_key crypto

Show all headers | View raw

On Mon, Sep 25, 2017 at 4:43 PM, David Howells <dhowells@redhat.com> wrote:
> Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
>> +     /* no ->update(); don't add it without changing big_key_crypt() nonce */
>
> Should update be a problem.  It's should be a complete payload replacement -
> kind of like unlink and add, but keeping the same key ID and description.

Not sure I parsed your message correctly, but that comment there was a
suggestion from Eric several months ago when I first posted it. The
idea is that the key shouldn't be reused with the same nonce, so in
case somebody ambitious comes along and tries to add an .update
function, they'll be reminded to take this into account. Alternatively
they might choose to just generate a new key, which is fine too.
Either way, it's a useful warning to have in place.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 1/2] security/keys: properly zero out sensitive key material in big_key "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-20 17:00 +0200
  [PATCH v7 2/2] security/keys: rewrite all of big_key crypto "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-20 17:00 +0200
    Re: [PATCH v7 2/2] security/keys: rewrite all of big_key crypto David Howells <dhowells@redhat.com> - 2017-09-25 16:50 +0200
      Re: [PATCH v7 2/2] security/keys: rewrite all of big_key crypto "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-25 18:40 +0200

csiph-web